Sentinel segmentation fault after running voxl-uvc-server -v [camera id] -d
-
Thanks @Alex-Kushleyev . Do you know if there are any differences between using the voxl fork of libuvc vs compiling the master libuvc? I was thinking of just building the master libuvc but I am not sure if modalai did any changes to it.
-
@AndriiHlyvko , you can see the changes that we made to the original fork : https://github.com/modalai/libuvc/commits/modalai-master (just the three top commits).
You may definitely try to use the latest master from the official repo, but we have not tested it. I believe there was some discussion recently about moving our code to latest, but we have not done it yet.
Alex
-
@Alex-Kushleyev just tested with latest master. The seg fault is gone and it seems to be working fine. One new problem that I have after moving to libuvc master is that the video stream from the boson+ looks wrong (the video is green
). Its only wrong for boson+ and not the boson. I'll keep debugging the issue. I was thinking maybe the boson+ sends incomplete frames in the uvc callback but I'm not sure. -
@Alex-Kushleyev figured it out. I had a bug that I introduced. I broke the mapping between UVC_FRAME_FORMAT enum and the voxl IMAGE_FORMAT enum in my fork of the uvc-server. Right now uvc streaming is working well with the boson+
-
@AndriiHlyvko , that's great!
If you are willing to help out and share your changes on top of libuvc master, it should help us get this updated more quickly
Thank you
Alex
-
@Alex-Kushleyev sure. Should I make a merge request for it and tag you in it?
-
@AndriiHlyvko , yes and please tag @Eric-Katzfey who will probably review and merge.
Thank you!
Alex
-
Hey @Alex-Kushleyev and @Eric-Katzfey here is the MR https://gitlab.com/voxl-public/voxl-sdk/third-party/voxl-libuvc/-/merge_requests/3#59f81c123b3abbcb97274545796dd18706c3e106
-
@AndriiHlyvko , Thank you! I will ask @Eric-Katzfey to review at his convenience.
-
I just ran into the same issue while testing Boson (in my case I was testing the 16-bit Boson streaming mode). The libuvc issue caused a crash, since i did not use a fixed version of libuvc. However, what actually caused the buffer overflow was the fact that Boson was reporting smaller buffer requirements for RAW16 during query (it was reporting
width * height * 1.5, just like for YUV, but actual frame size waswidth * height * 2, so uvc pipeline allocated smaller buffer and overflow happened with the full frame came in.Was this the same issue with your Boson tests or did you experience something else?
Thanks!
Alex
